exclude apparent resample when summarizing metrics #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #714. :)
Another approach here would be not to calculate metrics from that resample at all, returning early from
append_metrics()with a 0-row tibble. This feels somewhat user-hostile, though also we'd need some way to attach the resample id"Apparent"and.configentry to that tibble—dropping NAs in the rest of a 1-row tibble could be an option, butcollect_metrics()would still need to know what to know about the NAs in that case. This PRs opts to makeestimate_tune_results()(and thuscollect_metrics()andcompute_metrics()) aware of apparent resamples, still calculating metrics for them as normal but excluding them from summarizations.