Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set connecttimeout with user option (Fixes #318) #321

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+10 −1
Open

Set connecttimeout with user option (Fixes #318) #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c412acc
Set connecttimeout with user option (Fixes #318)
CorradoLanera Feb 11, 2025
286d017
Update NEWS.md
hadley Feb 12, 2025
eaeb539
Merge commit 'b692a7d820e1de5d2cb9f80d81d59efc0c9a2ff4'
hadley Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# ellmer (development version)

* All providers now allow for up to 60s for the underlying curl connection
phase, alongside the existing 60s timeout. Some providers are known to time
out on complex queries early otherwise. You can increase this with, e.g.,
`option(ellmer_connecttimeout_s = 120)` (#318, @CorradoLanera).

* `Chat$tokens()` now returns a data frame of tokens, correctly aligned to the
individual turn. The print method now uses this to show how many input/output
tokens each turn used (#354).
Expand Down
6 changes: 5 additions & 1 deletion R/httr2.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,11 @@ on_load(chat_perform_async_stream <- coro::async_generator(function(provider, re
# Request helpers --------------------------------------------------------------

ellmer_req_timeout <- function(req, stream) {
req_options(req, timeout = getOption("ellmer_timeout_s", 60))
req_options(
req,
timeout = getOption("ellmer_timeout_s", 60),
connecttimeout = getOption("ellmer_connecttimeout_s", 60),
)
}

ellmer_req_credentials <- function(req, credentials_fun) {
Expand Down
Loading