Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip annotation labels #6322

Merged
merged 4 commits into from
Mar 25, 2025
Merged

Conversation

teunbrand
Copy link
Collaborator

This PR aims to fix #6316.

Briefly, it skips label extraction when the mapping was constructed using the aes_all() function. This is communicated through a subclass. The layers from annotation() and expand_limits() functions are thereby not contributing to labels.

@teunbrand teunbrand requested review from thomasp85 March 11, 2025 10:28
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit f672845 into tidyverse:main Mar 25, 2025
13 checks passed
@teunbrand teunbrand deleted the skip_annotation_labels branch March 25, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprioritise annotations in deriving labels
2 participants