Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support single node persistence and authentication #283

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

efirs
Copy link
Collaborator

@efirs efirs commented Jun 4, 2023

This separates the behavior of dev start and local up commands. The dev start behaves as before, starts ephemeral, unauthenticated developer instance. The local up command starts persistent authenticated instance.

By default data directory is located at /var/lib/tigris, can be changed by --data-dir parameter. Bootstrap is only happen if the directory is empty.

On Unix systems, container owner is authenticated as instance administrator by Unix socket peer credentials.

By default on Windows or optionally on Unix (--token-admin-auth) system administrator is authenticated using a token generated on system bootstrap.

On authenticated instance, authentication can be temporary disabled by --skip-auth option of local up command.

This PR is dependent on: tigrisdata-archive/tigris#1247

@efirs efirs force-pushed the persistence branch 3 times, most recently from 164843b to ce4e76f Compare June 4, 2023 08:41
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage: 45.50% and project coverage change: -2.25 ⚠️

Comparison is base (98f0e8f) 49.06% compared to head (fd5c37f) 46.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #283      +/-   ##
==========================================
- Coverage   49.06%   46.81%   -2.25%     
==========================================
  Files          51       51              
  Lines        3522     3659     +137     
==========================================
- Hits         1728     1713      -15     
- Misses       1645     1788     +143     
- Partials      149      158       +9     
Impacted Files Coverage Δ
config/config.go 46.75% <ø> (ø)
login/login.go 7.31% <0.00%> (-0.10%) ⬇️
scaffold/scaffold.go 16.92% <0.00%> (ø)
util/util.go 53.84% <20.00%> (-3.17%) ⬇️
cmd/local.go 57.14% <48.55%> (-11.45%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@efirs efirs force-pushed the persistence branch 2 times, most recently from c5a64fc to cdad784 Compare June 6, 2023 00:04
efirs added 2 commits June 6, 2023 21:31
This separates the behavior of `dev start` and `local up` commands.
The `dev start` behaves as before, starts ephemeral, unauthenticated developer instance.
The `local up` command starts persistent authenticated instance.

By default data directory is located at `/var/lib/tigris`, can be
changed by `--data-dir` parameter. Bootstrap is only happen if the
directory is empty.

On Unix systems, container owner is authenticated as instance
administrator by Unix socket peer credentials.

By default on Windows or optionally on Unix (`--token-admin-auth`) system administrator
is authenticated using a token generated on system bootstrap.

On authenticated instance, authentication can be temporary disabled by
`--skip-auth` option of `local up` command.

This PR is dependent on: tigrisdata-archive/tigris#1247
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant