fix tests

timholy · Sep 3, 2023 · 639bceb · 639bceb
1 parent d8977ef
commit 639bceb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/parallel_progress.jl b/src/parallel_progress.jl
@@ -358,8 +358,10 @@ has_finished(p::ProgressThresh) = p.triggered
 has_finished(p::ProgressUnknown) = p.done
 has_finished(p::ParallelProgress) = isfakechannel(p.channel)
 has_finished(p::MultipleProgress) = isfakechannel(p.channel)
+has_finished(mc::MultipleChannel) = isfakechannel(mc)
 
-isfakechannel(_) = false
+isfakechannel(::AbstractChannel) = false
+isfakechannel(::RemoteChannel) = false
 isfakechannel(::FakeChannel) = true
 isfakechannel(mc::MultipleChannel) = isfakechannel(mc.channel)
 

diff --git a/test/test_multiple.jl b/test/test_multiple.jl
@@ -30,11 +30,13 @@ end
         next!(p[1])
     end
     sleep(s)
-    @test !ProgressMeter.isfakechannel(p[1])
+    @test !ProgressMeter.isfakechannel(p.channel)
+    @test !ProgressMeter.isfakechannel(p[1].channel)
     @test !has_finished(p)
     next!(p[1])
     sleep(s)
-    @test ProgressMeter.isfakechannel(p[1])
+    @test ProgressMeter.isfakechannel(p.channel)
+    @test ProgressMeter.isfakechannel(p[1].channel)
     @test has_finished(p)
 
     println("Testing MultipleProgress with custom titles and color")