refactor: remove hardcoded versions for PlayFabParty and DepotDownloader #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! 🥳 Could you drop the DepotDownloader bits? There's hopefully no need to differentiate how we download depots from Steam between the stable and beta branches. |
|
Yeah, I didn't think that there would be need to differentiate how we download depots for both branches. But I thought about changing the version of DepotDownloader sometime due to SteamRE/DepotDownloader#450. And with this it would involve only changing the version and hash once, instead of changing the version 9 times and the hash once. But if you think that it's unnecessary, I will drop it. |
|
Ah, that makes a lot of sense, all good! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you've mentioned in #54, we may need an update for PlayFabParty, so this would make changing the versions for both PlayFabParty and DepotDownloader easier.