if $text is NULL or Empty, return original text

tintnaingwinn · Oct 1, 2019 · 2dd30f8 · 2dd30f8
1 parent 441ec70
commit 2dd30f8
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 5 deletions.
diff --git a/src/MyanFont.php b/src/MyanFont.php
@@ -20,7 +20,7 @@ class MyanFont
     public static function zg2uni($text = '')
     {
         if (self::isEmptyString($text)) {
-            return '';
+            return $text;
         }
 
         $font = self::ZgOrUni($text);
@@ -44,7 +44,7 @@ public static function zg2uni($text = '')
     public static function uni2zg($text)
     {
         if (self::isEmptyString($text)) {
-            return '';
+            return $text;
         }
 
         $font = self::ZgOrUni($text);

diff --git a/tests/MyanFontTest.php b/tests/MyanFontTest.php
@@ -46,13 +46,26 @@ public function convert_uni2zg()
     public function null_convert()
     {
         $zg = MyanFont::uni2zg(null);
-        $this->assertNotNull($zg);
+        $this->assertNull($zg);
 
         $uni = MyanFont::zg2uni(null);
-        $this->assertNotNull($uni);
+        $this->assertNull($uni);
 
         $font = MyanFont::isZgOrUni(null);
-        $this->assertNotNull($font);
+        $this->assertEquals($font, self::UNICODE);
+    }
+
+    /** @test */
+    public function empty_string_convert()
+    {
+        $zg = MyanFont::uni2zg('');
+        $this->assertEmpty($zg);
+
+        $uni = MyanFont::zg2uni('');
+        $this->assertEmpty($uni);
+
+        $font = MyanFont::isZgOrUni('');
+        $this->assertEquals($font, self::UNICODE);
     }
 
     /** @test */