Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update README with some links and clarifications #334

Merged
merged 1 commit into from
Jan 16, 2025
Merged

docs: update README with some links and clarifications #334

merged 1 commit into from
Jan 16, 2025

Conversation

deadprogram
Copy link
Member

This PR updates the README with some links and clarifications for readability.

dkegel-fastly
dkegel-fastly approved these changes Jan 15, 2025
View reviewed changes
Copy link

@dkegel-fastly dkegel-fastly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I might change "By using" to "When built with", but that's just taste.

ysoldak
ysoldak approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@ysoldak ysoldak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deadprogram
Copy link
Member Author

Thanks @dkegel-fastly and @ysoldak now merging.

@deadprogram deadprogram merged commit 0b655a6 into dev Jan 16, 2025
4 checks passed
@deadprogram deadprogram deleted the readme-updates branch January 16, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkegel-fastly dkegel-fastly dkegel-fastly approved these changes

@ysoldak ysoldak ysoldak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deadprogram @ysoldak @dkegel-fastly