SANY: Remove unused stats feature from commandline. #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathieuBordere
force-pushed
the
947-sany-commandline
branch
from
2b38609
to
ca3f11f
Compare
|
@MathieuBordere You will have to amend and sign the git commit, and then force-push it to this branch: The DCO checks needs to find something like Signed-off-by: Markus Alexander Kuppe <github.com@...> in the commit message. |
MathieuBordere
force-pushed
the
947-sany-commandline
branch
from
ca3f11f
to
ab5331a
Compare
ahelwer
approved these changes
Nov 7, 2024
lemmy
reviewed
Nov 7, 2024
| @@ -436,8 +420,6 @@ else if (args[i].equals("-L") || args[i].equals("-l")) | |||
| doLevelChecking = !doLevelChecking; | |||
| else if (args[i].equals("-D") || args[i].equals("-d")) | |||
| doDebugging = !doDebugging; | |||
| else if (args[i].equals("-STAT") || args[i].equals("-stat")) | |||
There was a problem hiding this comment.
Please continue to accept the parameter. While it can be ignored, we should avoid breaking any existing scripts that may still pass this parameter, regardless of the reason.
Signed-off-by: Mathieu Bordere <[email protected]>
Signed-off-by: Mathieu Bordere <[email protected]>
MathieuBordere
force-pushed
the
947-sany-commandline
branch
from
ab5331a
to
ae3791d
Compare
lemmy
approved these changes
Nov 7, 2024
ahelwer
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #947 , a little PR to get me started.
I also took the liberty to remove a line of code that was causing the synopsis to be shown twice.
now looks like