[18Norway] Updated harbor #10990
Merged
[18Norway] Updated harbor #10990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ollybh
reviewed
Jul 11, 2024
Co-authored-by: Oliver Burnett-Hall <[email protected]>
ollybh
added
new games
|
The harbor logic where broken, it was possible to place a token in any open city |
patrikolesen
force-pushed
the
18_norway_update_harbor
branch
from
a27fbfb
to
4753794
Compare
|
Sorry for the mess, but now it should be ok to review again |
ollybh
reviewed
Sep 15, 2024
Co-authored-by: Oliver Burnett-Hall <[email protected]>
ollybh
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before clicking "Create"
masterpinsorarchive_alpha_gameslabel if this change will break existing gamesdocker compose exec rack rubocop -adocker compose exec rack rakeImplementation Notes
Explanation of Change
Screenshots
Any Assumptions / Hacks