[18ESP] implement minor rule changes #11165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ollybh
requested changes
Aug 26, 2024
There was a problem hiding this comment.
I've added a few suggestions for changes.
The biggest would be moving some things from train events to phase statuses, so that more information is visible to players on the game info page. Here's what 1858’s info page looks like late in the game:
Here you can still see what types of track are currently available – if the availability of the dual gauge track had been linked to an event on the first 5E/4M train then this event timing would disappear once that train had been bought.
bentziaxl
force-pushed
the
18esp_no_auction
branch
2 times, most recently
from
6157c45
to
3e97cc5
Compare
fix 3 times jumps update acquire rules fix p values, 9 tile 15 allow all train buy, acquire only on phase 3, only north corps update minor fixes, closing minor, multiple takeovers remove auction fix mising minors closing fix tenders and deleted tokens fix p2 fix castellion tile fix aranjuaz tiles update latest rules fix par prices in auction fix paring price remove extra icons after phase 5 only one pass a turn fix tender ownership location fix minor bugs remove old test spec fix ran_harbor added method delete extra put statement handle comments and add test fixture fix latest issues fix latest comments
bentziaxl
force-pushed
the
18esp_no_auction
branch
from
a1f61fd
to
2013b27
Compare
|
@bentziaxl Please don't rebase / force push to a branch once a review is in process. It makes it impossible to see what has been changed in response to review comments. |
added 2 commits
August 29, 2024 23:22
ollybh
reviewed
Aug 29, 2024
added 2 commits
August 30, 2024 06:42
ollybh
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in last ORs north corps jump 2 times and not 3
fix private abilities
one mountain pass open per OR turn
can take over multiple minors
minors close instead of stop operating, no auction
remove extra icons after phase 5
p2 can not be sold
tender can be bought from other corporations and also the bank