Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[System18] corrects price change when emr issuing #11167

Merged

Conversation

philcampeau
Copy link
Collaborator

@philcampeau philcampeau commented Aug 21, 2024

Fixes #11161

Before clicking "Create"

  • Branch is derived from the latest master
  • Add the pins or archive_alpha_games label if this change will break existing games
  • Code passes linter with docker compose exec rack rubocop -a
  • Tests pass cleanly with docker compose exec rack rake

Implementation Notes

Explanation of Change

According to the rules (see below), shares issued during EMR in incremental cap games should only drop the price by a single space. The code had movement: :left_share. Corrected to :left_block.

This will only affect existing incremental cap games where multiple shares were issued during EMR.

Screenshots

image

Any Assumptions / Hacks

@philcampeau philcampeau added the archive_alpha_games Needs alpha games archiving label Aug 21, 2024
@bentziaxl bentziaxl merged commit 38a7299 into tobymao:master Aug 21, 2024
1 check passed
@philcampeau philcampeau deleted the 11161---system18-EMR-issuing-fix branch September 16, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archive_alpha_games Needs alpha games archiving
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[System18: Poland] Price drops multiple times when issuing stock in EMR
2 participants