Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18Uruguay] Company should get full cap after nationalization and no destination bonus #11208

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

patrikolesen
Copy link
Contributor

@patrikolesen patrikolesen commented Sep 12, 2024

Company should get full cap but no destination bonus after nationalization

Fixes #11060

Before clicking "Create"

  • Branch is derived from the latest master
  • Add the pins or archive_alpha_games label if this change will break existing games
    This can break existing games
  • Code passes linter with docker compose exec rack rubocop -a
  • Tests pass cleanly with docker compose exec rack rake

Implementation Notes

Explanation of Change

Screenshots

Any Assumptions / Hacks

Company should get full cap after nationalization and no destination bonus
Copy link
Collaborator

@ollybh ollybh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine.
I assume that the extra money in the companies might break some existing games, so these will need archiving or pinning. Right?

@ollybh ollybh added the archive_alpha_games Needs alpha games archiving label Sep 12, 2024
@patrikolesen
Copy link
Contributor Author

Yes exactly, the extra money might break some existing game.

@ollybh ollybh merged commit 89a1e08 into tobymao:master Oct 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
18Uruguay archive_alpha_games Needs alpha games archiving
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[18Uruguay] company not receiving full capital after nationalization
2 participants