Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auto-routing] Clears previous routes before running #11226

Closed
wants to merge 3 commits into from

Conversation

philcampeau
Copy link
Collaborator

Fixes #10136

Before clicking "Create"

  • Branch is derived from the latest master
  • Add the pins or archive_alpha_games label if this change will break existing games
  • Code passes linter with docker compose exec rack rubocop -a
  • Tests pass cleanly with docker compose exec rack rake

Implementation Notes

Explanation of Change

Now, when a player clicks the Auto button, it doesn't update the routes. This change causes the Auto button to clear the existing routes before running its script.

I think this makes more sense than the current application.

In addition to saving everyone clicks, I had a new player tell me well into our second game on the site that he had just then realized that auto-routing wasn't updating his previous routes, and he'd been running under for the majority of the games we had played.

Open to feedback.

Screenshots

Any Assumptions / Hacks

@philcampeau philcampeau reopened this Sep 16, 2024
@roseundy
Copy link
Collaborator

I disagree with the intent of this PR.

@philcampeau
Copy link
Collaborator Author

Yeah, having read your argument against it on the original request, I agree. Closing.

@philcampeau philcampeau deleted the auto-route branch September 16, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[autoroute] clear routes if any connectivity changed or if player clicks "Auto"
2 participants