Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added package saq.web to build #84

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Added package saq.web to build #84

merged 1 commit into from
Aug 31, 2023

Conversation

grigi
Copy link
Contributor

@grigi grigi commented Aug 31, 2023

Hi, thanks for releasing a new version, but it seems that the saq.web pacakges are not included. (my bad, I didn't verify that setup.py didn't use find_packages())

I also updated the CHANGELOG assuming the next release should be called v0.11.2

@tobymao
Copy link
Owner

tobymao commented Aug 31, 2023

the changelog should not be manual, i will never update it, you need to add an automatic changelog tool like semantic commits or something

@tobymao tobymao merged commit 35d9f4f into tobymao:master Aug 31, 2023
4 checks passed
@grigi
Copy link
Contributor Author

grigi commented Aug 31, 2023

the changelog should not be manual, i will never update it, you need to add an automatic changelog tool like semantic commits or something

Noted, I'll look for something that can automate it or get rid of it.

Otherwise I noticed another packaging mistake 😭

RuntimeError: Directory '/home/grigi/work/magneto/.pyenv/lib/python3.11/site-packages/saq/web/static' does not exist

I'm making dinner now and dealing with the kids, so I'll only get to it tomorrow morning. Sorry

@tobymao
Copy link
Owner

tobymao commented Aug 31, 2023

219e702

can you check if this does it when you have time?

@tobymao
Copy link
Owner

tobymao commented Aug 31, 2023

7e6e773

@grigi
Copy link
Contributor Author

grigi commented Aug 31, 2023

7e6e773

Yay! It's working perfectly now!
Thank you sir 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants