fix(prql): Rewrote tests to use validate_all() to separate the parser and generator tests.
#4097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enerator tests could be separated.
|
We usually do |
|
@JJHCool I see that several tests were removed, why did this happen? |
georgesittas
added a commit
that referenced
this pull request
Sep 10, 2024
This reverts commit 75e6406.
|
I reverted this, in the future please don't remove tests or explain why they were removed. It's hard to notice using just git's diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the PRQL tests to use
validate_all(), instead ofvalidate_identity(), which will allow separation between the parser and the generator tests.