Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser)!: Parse VALUES & query modifiers in wrapped FROM clause #4135

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

VaggelisD
Copy link
Collaborator

Fixes #4133

When parsing a FROM clause, we'll attempt to _parse_table() which in turn will call _parse_subquery(table=True) if the clause is wrapped.

The nested exp.Values will be parsed into this at _parse_select() but the following query modifiers (e.g. joins) will not be consumed since this is not exp.Query / exp.Table.

This PR transforms/wraps this to a table to bypass this.

@tobymao tobymao merged commit 77a514d into main Sep 19, 2024
6 checks passed
@tobymao tobymao deleted the vaggelisd/from_values branch September 19, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure to parse valid Postgres query
2 participants