fix(parser)!: Parse VALUES & query modifiers in wrapped FROM clause #4135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4133
When parsing a
FROM
clause, we'll attempt to_parse_table()
which in turn will call_parse_subquery(table=True)
if the clause is wrapped.The nested
exp.Values
will be parsed intothis
at_parse_select()
but the following query modifiers (e.g. joins) will not be consumed sincethis
is notexp.Query
/exp.Table
.This PR transforms/wraps
this
to a table to bypass this.