New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bigquery): Parse REGEXP_SUBSTR as exp.RegexpExtract #4358

Merged

georgesittas merged 1 commit into main from vaggelisd/bq_regexp_substr

Nov 7, 2024

Collaborator

VaggelisD commented Nov 7, 2024

This PR parses REGEXP_SUBSTR into exp.RegexpExtract, as acccording to the docs it's a synonym for REGEXP_EXTRACT. For the tests:

The cases in bigquery.py are organized into a single function
The case in snowflake.py is wrong, probably copy-pasted from the "snowflake" line. It's only failing now as REGEXP_SUBSTR is no longer Anonymous for BQ

Docs

BQ REGEXP_SUBSTR


          feat(bigquery): Parse REGEXP_SUBSTR as exp.RegexpExtract

georgesittas approved these changes

View reviewed changes

georgesittas merged commit e337a42 into main

6 checks passed

georgesittas deleted the vaggelisd/bq_regexp_substr branch

November 7, 2024 10:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet