state always need to implement Clone #2972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanns
force-pushed
the
fix-doc-cloneable-state
branch
from
f869f05
to
576b976
Compare
jplatte
reviewed
Oct 10, 2024
There was a problem hiding this comment.
Honestly, looking at what's left: Wouldn't it maybe make more sense to just outright delete this section of the docs? The explanation for the Clone bound isn't really much of an explanation, is it?
And for other bounds, you also don't usually have any special docs to justify them. I think this section was only useful to have back when there were actually some circumstances when you didn't need to impl Clone for the toplevel state type.
Does that make sense to you?
|
Yes I agree |
jplatte
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2821