tracing-journald: make level mappings configurable #2347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
little-dude
requested review from
hawkw,
davidbarsky and
a team
as code owners
little-dude
force-pushed
the
tracing-journald-priority-mappings
branch
from
bd18969 to
7673d7c
Compare
little-dude
commented
Oct 13, 2022
hawkw
reviewed
Oct 13, 2022
little-dude
force-pushed
the
tracing-journald-priority-mappings
branch
2 times, most recently
from
217e857 to
ca8c393
Compare
Ralith
reviewed
Oct 15, 2022
little-dude
force-pushed
the
tracing-journald-priority-mappings
branch
2 times, most recently
from
6eb08e5 to
0d2b814
Compare
|
CI docs builds seem to be failing across the board, so that's unrelated... |
hawkw
approved these changes
Oct 20, 2022
little-dude
force-pushed
the
tracing-journald-priority-mappings
branch
from
8470211 to
b86aabc
Compare
I added an example and a test. |
little-dude
force-pushed
the
tracing-journald-priority-mappings
branch
from
7ab29e7 to
b28463a
Compare
little-dude
force-pushed
the
tracing-journald-priority-mappings
branch
from
b28463a to
78e545e
Compare
little-dude
requested review from
hawkw and
Ralith
and removed request for
davidbarsky,
hawkw and
Ralith
|
Hello, |
|
It needs to be reviewed because I added a test and an example since the first review. |
|
@t-lintanf also note that this MR is for master currently. If you need this in 0.1, it'll need to be backported. |
|
ah, sorry i didn't see the most recent changes, my bad! |
hawkw
requested changes
Feb 21, 2023
Comment on lines
+14
to
+24
| registry | ||
| .with( | ||
| subscriber | ||
| // We can tweak the mappings between the trace level and | ||
| // the journal priorities. | ||
| .with_priority_mappings(PriorityMappings { | ||
| info: Priority::Informational, | ||
| ..PriorityMappings::new() | ||
| }), | ||
| ) | ||
| .init(); |
There was a problem hiding this comment.
I think this example ought to be in the RustDoc documentation for the with_priority_mappings method, rather than in the general example file.
This was referenced Aug 7, 2023
|
Hey @little-dude do you think we could get this merged? Otherwise I could pick it up as well... |
|
@hawkw, @davidbarsky looks like this PR is stale, applied the changes to current master and opened a new PR ( #2824 ). |
hds
pushed a commit
that referenced
this pull request
Nov 19, 2024
This allows to manually map tracing levels to journald levels. It seems that @little-dude, who started the original PR, doesn't have time to finish this, so I picked it up. Reapplied the changes to the newest master branch and fixed the latest comments/issues. This will also fix/close: Closes #2649 Closes #2661 Closes #2347 (the original pr)
hds
pushed a commit
that referenced
this pull request
Nov 20, 2024
This allows to manually map tracing levels to journald levels. It seems that @little-dude, who started the original PR, doesn't have time to finish this, so I picked it up. Reapplied the changes to the newest master branch and fixed the latest comments/issues. This will also fix/close: Closes #2649 Closes #2661 Closes #2347 (the original pr)
hds
pushed a commit
that referenced
this pull request
Nov 20, 2024
This allows to manually map tracing levels to journald levels. It seems that @little-dude, who started the original PR, doesn't have time to finish this, so I picked it up. Reapplied the changes to the newest master branch and fixed the latest comments/issues. This will also fix/close: Closes #2649 Closes #2661 Closes #2347 (the original pr)
hds
pushed a commit
that referenced
this pull request
Nov 20, 2024
This allows to manually map tracing levels to journald levels. It seems that @little-dude, who started the original PR, doesn't have time to finish this, so I picked it up. Reapplied the changes to the newest master branch and fixed the latest comments/issues. This will also fix/close: Closes #2649 Closes #2661 Closes #2347 (the original pr)
hds
pushed a commit
that referenced
this pull request
Nov 21, 2024
This allows to manually map tracing levels to journald levels. It seems that @little-dude, who started the original PR, doesn't have time to finish this, so I picked it up. Reapplied the changes to the newest master branch and fixed the latest comments/issues. This will also fix/close: Closes #2649 Closes #2661 Closes #2347 (the original pr)
hds
pushed a commit
that referenced
this pull request
Nov 22, 2024
This allows to manually map tracing levels to journald levels. It seems that @little-dude, who started the original PR, doesn't have time to finish this, so I picked it up. Reapplied the changes to the newest master branch and fixed the latest comments/issues. This will also fix/close: Closes #2649 Closes #2661 Closes #2347 (the original pr)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
My company uses different conventions to map tracing levels to journald priorities. I need to be able to configure the mappings to integrate with existing services.
Solution
Do not hardcode the mappings. Instead store the mappins to use in the subscriber.