Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make flake8 regex more precise to avoid false positives #185

Merged
merged 2 commits into from
Mar 2, 2024
Merged

make flake8 regex more precise to avoid false positives #185

merged 2 commits into from
Mar 2, 2024

Conversation

henglert
Copy link
Contributor

No description provided.

@henglert
Copy link
Contributor Author

I had to change the "testThatViolationsCanBeParsedFromFileContainingNoise" also. When you look at the flake8-failure.log file, I only see a single flake8 warning on line 4, all other lines are not flake8. The test before (HOME=/var/jenkins_home) was a false positive in my opinion.

@tomasbjerre tomasbjerre merged commit 50ffc15 into tomasbjerre:feature/issue-184-flake8-regex-too-unspecific Mar 2, 2024
4 checks passed
@tomasbjerre
Copy link
Owner

thanks!

@tomasbjerre
Copy link
Owner

This is now released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henglert @tomasbjerre