-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a github actions runner file #49
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh thanks! I see you may be still tweaking this, so some interim notes.
.github/workflows/rust.yml
Outdated
tags-ignore: | ||
- 'v*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we don't need to ignore any tags?
.github/workflows/rust.yml
Outdated
pull_request: | ||
branches: | ||
- '*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's common to have either on: push
or on: pull_request
. Having both causes very duplicate CI runs most of the time. We're usually using push
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I was just copying our innernet workflow, but my preferred setup is like so:
on:
push:
branches:
- main
pull_request:
I'll change it to that.
Unfortunately this seems to be failing on a build of The portaudio build seems to be passing I looked deeper and the portaudio crate is still pulling the portaudio source from an HTTP server unfortunately. Maybe we should fork it and have it include the portaudio source as a submodule instead... |
No description provided.