Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a github actions runner file #49

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add a github actions runner file #49

wants to merge 8 commits into from

Conversation

bschwind
Copy link
Member

No description provided.

Copy link
Member

@strohel strohel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thanks! I see you may be still tweaking this, so some interim notes.

Comment on lines 7 to 8
tags-ignore:
- 'v*'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we don't need to ignore any tags?

Comment on lines 9 to 11
pull_request:
branches:
- '*'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's common to have either on: push or on: pull_request. Having both causes very duplicate CI runs most of the time. We're usually using push.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I was just copying our innernet workflow, but my preferred setup is like so:

on:
  push:
    branches:
      - main
  pull_request:

I'll change it to that.

@bschwind
Copy link
Member Author

Unfortunately this seems to be failing on a build of portaudio on macos. It doesn't fail on my local mac machine because a different target architecture is being set (aarch64-apple-darwin24 for me, arm-apple-darwin23 for this CI), and possibly a different version of a C compiler.

The portaudio build seems to be passing -Werror and while that's fine and dandy for them as a project, ideally we would not pass that flag when building it as a dependency.

I looked deeper and the portaudio crate is still pulling the portaudio source from an HTTP server unfortunately. Maybe we should fork it and have it include the portaudio source as a submodule instead...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants