Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat: improve backpressure gossipsub batch #248

Merged
merged 16 commits into from
Jul 11, 2023

Conversation

Freyskeyd
Copy link
Member

@Freyskeyd Freyskeyd commented Jun 23, 2023

Description

This PR aims to allow us to have numbers for the benchmarks.

Here's a non-exhaustive list of what it covers:

  • Upgrade various deps
  • Adding metrics system and Prometheus/Grafana config
  • Switch to InMemory model for PendingCertificates
  • Refactor some part of the project to make it more performant and reliable

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@Freyskeyd Freyskeyd requested a review from a team as a code owner June 23, 2023 09:36
@Freyskeyd Freyskeyd changed the base branch from main to feature/improve-backpressure-gossipsub June 23, 2023 09:36
@Freyskeyd Freyskeyd changed the title Feature/improve backpressure gossipsub batch feat: improve backpressure gossipsub batch Jun 23, 2023
@Freyskeyd Freyskeyd force-pushed the feature/improve-backpressure-gossipsub branch from c3caf89 to 72dba69 Compare June 26, 2023 09:44
@Freyskeyd Freyskeyd force-pushed the feature/improve-backpressure-gossipsub-batch branch from 42aba3b to c839537 Compare June 27, 2023 09:32
@Freyskeyd Freyskeyd force-pushed the feature/improve-backpressure-gossipsub branch 2 times, most recently from f922ce9 to 4a6286b Compare June 27, 2023 10:31
@Freyskeyd Freyskeyd force-pushed the feature/improve-backpressure-gossipsub-batch branch from bbafc34 to b5ce9a0 Compare June 27, 2023 13:05
@Freyskeyd Freyskeyd changed the base branch from feature/improve-backpressure-gossipsub to main June 27, 2023 13:05
@Freyskeyd Freyskeyd force-pushed the feature/improve-backpressure-gossipsub-batch branch from b5ce9a0 to 430038e Compare June 27, 2023 13:06
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #248 (7308f90) into main (49b17e9) will decrease coverage by 1.86%.
The diff coverage is 63.84%.

❗ Current head 7308f90 differs from pull request most recent head 20da5bb. Consider uploading reports for the commit 20da5bb to get more accurate results

@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
- Coverage   54.99%   53.14%   -1.86%     
==========================================
  Files         192      198       +6     
  Lines        9626     9990     +364     
==========================================
+ Hits         5294     5309      +15     
- Misses       4332     4681     +349     
Impacted Files Coverage Δ
crates/topos-certificate-spammer/src/lib.rs 0.35% <ø> (ø)
crates/topos-metrics/src/storage.rs 0.00% <0.00%> (ø)
crates/topos-p2p/src/behaviour.rs 100.00% <ø> (ø)
crates/topos-p2p/src/behaviour/discovery.rs 71.05% <ø> (-0.38%) ⬇️
crates/topos-p2p/src/behaviour/peer_info.rs 100.00% <ø> (ø)
...ates/topos-p2p/src/behaviour/transmission/codec.rs 1.81% <ø> (ø)
...s/topos-p2p/src/behaviour/transmission/protocol.rs 0.00% <ø> (-100.00%) ⬇️
crates/topos-p2p/src/event.rs 46.66% <0.00%> (-6.28%) ⬇️
crates/topos-p2p/src/lib.rs 85.00% <ø> (ø)
crates/topos-p2p/src/tests/dht.rs 40.00% <ø> (ø)
... and 40 more

... and 9 files with indirect coverage changes

@Freyskeyd Freyskeyd force-pushed the feature/improve-backpressure-gossipsub-batch branch 13 times, most recently from 7db2903 to f85cf81 Compare July 4, 2023 10:57
crates/topos-p2p/src/event.rs Outdated Show resolved Hide resolved
crates/topos-p2p/src/network.rs Outdated Show resolved Hide resolved
crates/topos-tce-storage/src/connection.rs Outdated Show resolved Hide resolved
crates/topos-tce-storage/src/connection.rs Outdated Show resolved Hide resolved
crates/topos-tce-storage/src/connection.rs Outdated Show resolved Hide resolved
crates/topos-tce-broadcast/src/double_echo/mod.rs Outdated Show resolved Hide resolved
crates/topos-tce-broadcast/src/lib.rs Outdated Show resolved Hide resolved
crates/topos-tce-broadcast/src/lib.rs Show resolved Hide resolved
crates/topos-tce-storage/src/client.rs Show resolved Hide resolved
@Freyskeyd Freyskeyd force-pushed the feature/improve-backpressure-gossipsub-batch branch 8 times, most recently from 4e844b7 to 5905254 Compare July 11, 2023 10:53
Signed-off-by: Simon Paitrault <[email protected]>
Signed-off-by: Simon Paitrault <[email protected]>
Signed-off-by: Simon Paitrault <[email protected]>
Signed-off-by: Simon Paitrault <[email protected]>
Signed-off-by: Simon Paitrault <[email protected]>
Signed-off-by: Simon Paitrault <[email protected]>
Signed-off-by: Simon Paitrault <[email protected]>
Signed-off-by: Simon Paitrault <[email protected]>
Signed-off-by: Simon Paitrault <[email protected]>
@Freyskeyd Freyskeyd force-pushed the feature/improve-backpressure-gossipsub-batch branch 2 times, most recently from 252817b to d78b7f7 Compare July 11, 2023 14:02
@Freyskeyd Freyskeyd force-pushed the feature/improve-backpressure-gossipsub-batch branch from d78b7f7 to 7308f90 Compare July 11, 2023 14:42
Signed-off-by: Simon Paitrault <[email protected]>
@Freyskeyd Freyskeyd merged commit 9d1089f into main Jul 11, 2023
@Freyskeyd Freyskeyd deleted the feature/improve-backpressure-gossipsub-batch branch July 11, 2023 15:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants