Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a
From<i32>
impl for the GrpcCode enum. This allows users to easily convert the result of theGrpcErrorsAsFailures
back into an enum.Fixes: #505
Motivation
I recently had to implement a custom
TraceLayer
on-failure struct, and it made sense to reuse theGrpcErrorsAsFailures
class to extract the status. Unfortunately, it returns the error code as aNoneZeroI32
but tower_http doesn't have a convenient way to map this back to the num.Implementing this is trivial, but still feels like a reasonable addition to this library.
Solution
I feel like this solution is pretty self-explanatory :).