Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: public/mockServiceWorker.jsをeslint.config.jsのignoresに追加 #337

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

reiroop
Copy link
Contributor

@reiroop reiroop commented Nov 5, 2024

PR Type

configuration changes


Description

  • ESLintの設定ファイルにpublic/mockServiceWorker.jsを無視するように変更しました。
  • これにより、ESLintのチェックからこのファイルが除外されます。

Changes walkthrough 📝

Relevant files
Configuration changes
eslint.config.js
ESLint設定にmockServiceWorker.jsを無視する設定を追加                                   

eslint.config.js

  • public/mockServiceWorker.jsignoresリストに追加
+1/-1     

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

Copy link

github-actions bot commented Nov 5, 2024

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@reiroop reiroop requested a review from anko9801 November 5, 2024 07:10
@anko9801
Copy link
Contributor

anko9801 commented Nov 5, 2024

ignore と disable 消して ESLint を入れた状態でも指摘するものないよ~と言われてて、これってどうして設定入れてるのでしょうか

@reiroop
Copy link
Contributor Author

reiroop commented Nov 7, 2024

ignore と disable 消して ESLint を入れた状態でも指摘するものないよ~と言われてて、これってどうして設定入れてるのでしょうか

gen-api で生成される mockServiceWorker.js が lint を走らせると変更されていたからです、実行順次第で変更が入るのはあんまりよくないかなーって感じです

@reiroop reiroop merged commit 2f16b01 into main Nov 8, 2024
6 checks passed
@reiroop reiroop deleted the chore/add_mockServiceWorker_to_eslint_ignores branch November 8, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants