aws-sdk-go-v2 の V1: EndpointResolver を V2: EndpointResolverV2 + BaseEndpoint の形に書き換え
#2487
+87
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testが落ちていますが、どう直せばよいのか分からないので、レビューというよりは助けて欲しいです。 |
hijiki51
reviewed
Jul 24, 2024
| config.WithCredentialsProvider(credentials.NewStaticCredentialsProvider("ROOT", "PASSWORD", "")), | ||
| ) | ||
| _ = s3.NewFromConfig(cfg, func(o *s3.Options) { |
There was a problem hiding this comment.
この関数はテスト用のConfig作成用で、aws.Configを構築するためにいろいろしてるんだけど、s3.NewFromConfig はs3 client構築用の関数で、aws.Configに反映するものではないので、EndpointResolverV2の設定が反映されてなさそう
hijiki51
reviewed
Jul 24, 2024
| @@ -28,28 +30,39 @@ type S3FileStorage struct { | |||
| mutexes *utils.KeyMutex | |||
| } | |||
|
|
|||
| type customResolver struct { | |||
There was a problem hiding this comment.
BaseEndpointだけで動く気がしていて、CustomResolverはいらないと思う
もともとカスタムリゾルバっぽくしてたのは、BaseURL書き換えるにはそうするしかなかったから
一応非推奨だし
Because of this, we recommend that you don’t replace the EndpointResolverV2 implementation in your S3 client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(deps): update aws-sdk-go-v2 monorepo #2445
にて、EndpointResolverがDeprecatedとなっておりマージできなくて、調べたらV2に移行しろとの事だったため、以下のドキュメントを見ながら
V1: EndpointResolverからV2: EndpointResolverV2 + BaseEndpointに書き換えました。https://aws.github.io/aws-sdk-go-v2/docs/configuring-sdk/endpoints/
色々調べましたが、分からない所が多いまま修正したため、かなり不安です。