Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicated prometheus timeseries error caused by inprogress requests #324

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

freud14-tm
Copy link

What does this do?

Handle value error when we set should_instrument_requests_inprogress and use the provided registry.

Why do we need it?

To fix > Add a description of the problem the feature is trying to solve..

Who is this for?

Add information on what kind of persona the feature is for.

Linked issues

> Add a description of the problem the feature is trying to solve.

@freud14-tm
Copy link
Author

@trallnag Would it possible to run the workflows awaiting for approval and review this? It's a small PR.

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.22%. Comparing base (2e1568e) to head (f84e917).

Files with missing lines Patch % Lines
...rc/prometheus_fastapi_instrumentator/middleware.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
- Coverage   95.97%   95.22%   -0.76%     
==========================================
  Files           5        5              
  Lines         373      377       +4     
==========================================
+ Hits          358      359       +1     
- Misses         15       18       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inprogress requests causes duplicated prometheus timeseries error
1 participant