Refactor to make code more TypeScript compatible

[remcohaszing]

This change contains some refactors, mostly to make the code better compatible with TypeScript.

All require() calls were changed to the form
const identifier = require('specifier'). This is compatible with TypeScript’s verbatimModuleSyntax option, which is strongly recommended in order to produce valid library types.

All uses of lodash were changed to native JavaScript implementations. The lodash dependency was removed.

Static class assignments were changed to static class property syntax.

util.promisify usage was replaced with Node.js promise APIs.

[mifi]

we have to be careful now that we no longer run CI tests for the supported node versions 16 and 14, that features like fs/promises, stream/promises and Object.fromEntries are avail those node versions. Or maybe we'll just say that we make this TypeScript rewrite a major version so we don't have to worry about this anymore.

[mifi]

this will probably err in typescript when strict null checks is enabled. maybe better to do a streamLables.reduce(...)

[remcohaszing]

Why would this result in a TypeScript error? Reduce would definitely not help with this.

I strongly believe array.reduce should never be used.

[mifi]

the following code results in Object is possibly 'undefined'. typescript error when strict null checks is enabled (which i think makes typescript more accurate):

const progresses: Record<string, number> = { a: 1, b: 2, c:3 }
const labels = ['a', 'b', 'c']
let sum = 0;
for (const l of labels) {
  sum += progresses[l]
}

but then this also gives the same error, so ignore what i just suggested 🤦‍♂️

const sum = labels.reduce((acc, l) => acc + progresses[l], 0)

I misread your code and instead read it as a simple sum of elements. in that case this code does not produce the same ts error:

const sum = numbers.reduce((acc, n) => acc + n, 0)

but again ignore what i said.

as for using array.reduce i agree that it should be used sparingly, but as mentioned in your link it's nice for summing numbers:

It's only somewhat useful in the rare case of summing up numbers, which is allowed by default.

[remcohaszing]

we have to be careful now that we no longer run CI tests for the supported node versions 16 and 14, that features like fs/promises, stream/promises and Object.fromEntries are avail those node versions.

I agree. I double checked all their availabilities in the docs.

Or maybe we'll just say that we make this TypeScript rewrite a major version so we don't have to worry about this anymore.

I’m ok with this, but I don’t think it’s needed. I would like to replace the uuid dependency with crypto.randomUUID. That would raise the minimal version from 14.16 to 14.17. I don’t think that’s worth making a semver major release, but I didn’t include it yet so this PR doesn’t break anything.

[mifi]

ok, all good then!