Fix Companion deploys #3388
Merged
Fix Companion deploys #3388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems it's not working yet? |
|
Heroku was down for a long time yesterday. Which didn't allow me to try as I wanted. I am planning on tackling it today and I will update the channel once we have something 👍 |
|
Tested a deployment successfully https://github.com/transloadit/uppy/actions/runs/1674980731 This switches to docker. I only added a bit of work on top of @mifi detailed issue #3362. So if there's any credit for this fix it should be his. |
2 tasks
Murderlon
approved these changes
Jan 10, 2022
mifi
reviewed
Jan 10, 2022
Co-authored-by: Mikael Finstad <[email protected]>
|
I will go ahead and merge it. Can always have a hindsight review. |
github-actions bot
added a commit
that referenced
this pull request
Jan 10, 2022
| Package | Version | Package | Version | | -------------------- | ------- | -------------------- | ------- | | @uppy/drag-drop | 2.0.6 | @uppy/tus | 2.2.0 | | @uppy/image-editor | 1.1.1 | @uppy/utils | 4.0.5 | | @uppy/screen-capture | 2.0.6 | @uppy/robodog | 2.2.0 | | @uppy/transloadit | 2.1.0 | uppy | 2.4.0 | - @uppy/transloadit: ignore rate limiting errors when polling (Antoine du Hamel / #3418) - @uppy/tus: pause all requests in response to server rate limiting (Antoine du Hamel / #3394) - @uppy/transloadit: better defaults for rate limiting (Antoine du Hamel / #3414) - @uppy/companion: Fix Companion deploys (kiloreux / #3388) - meta: update aws-presigned-url example to use esm (Antoine du Hamel / #3413) - @uppy/image-editor: namespace input range css (Merlijn Vos / #3406) - @uppy/screen-capture: Add missing option to the screen capture types (Mustafa Navruz / #3400) - @uppy/drag-drop: fix `undefined is not a function` TypeError (Antoine du Hamel / #3397) - website: update december 2021 blog post (Antoine du Hamel / #3396) - website: Polished the latest update blog (AJvanLoon / #3390) - website: docs: fix typo in audio.md (heocoi / #3389) - website: 2.0-2.3 post draft (Artur Paikin / #3370)
Murderlon
added a commit
that referenced
this pull request
Jan 12, 2022
* main: dev: move configuration to a `.env` file (#3430) Update ci.yml (#3428) @uppy/transloadit: simplify `#onTusError` (#3419) Force include babel numeric separator (#3422) Release: [email protected] (#3420) @uppy/transloadit: ignore rate limiting errors when polling (#3418) @uppy/tus: pause all requests in response to server rate limiting (#3394) @uppy/transloadit: better defaults for rate limiting (#3414) Update BACKLOG.md Fix Companion deploys (#3388) update aws-presigned-url example to use esm (#3413) @uppy/image-editor: namespace input range css (#3406) Release: [email protected] (#3410) improve private ip check (#3403) Add missing option to the screen capture types (#3400) @uppy/drag-drop: fix `undefined is not a function` TypeError (#3397) website: update december 2021 blog post (#3396)
vymao
pushed a commit
to vymao/uppy
that referenced
this pull request
Mar 29, 2022
* main: dev: move configuration to a `.env` file (transloadit#3430) Update ci.yml (transloadit#3428) @uppy/transloadit: simplify `#onTusError` (transloadit#3419) Force include babel numeric separator (transloadit#3422) Release: [email protected] (transloadit#3420) @uppy/transloadit: ignore rate limiting errors when polling (transloadit#3418) @uppy/tus: pause all requests in response to server rate limiting (transloadit#3394) @uppy/transloadit: better defaults for rate limiting (transloadit#3414) Update BACKLOG.md Fix Companion deploys (transloadit#3388) update aws-presigned-url example to use esm (transloadit#3413) @uppy/image-editor: namespace input range css (transloadit#3406) Release: [email protected] (transloadit#3410) improve private ip check (transloadit#3403) Add missing option to the screen capture types (transloadit#3400) @uppy/drag-drop: fix `undefined is not a function` TypeError (transloadit#3397) website: update december 2021 blog post (transloadit#3396)
HeavenFox
pushed a commit
to docsend/uppy
that referenced
this pull request
Jun 27, 2023
* Change compilation to postinstall * Deploy * Restore shape * Reduce builds * Use docker instead * Use port as second variable * Change * Minor fixes * Update .github/workflows/companion-deploy.yml Co-authored-by: Mikael Finstad <[email protected]> Co-authored-by: Mikael Finstad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3362