Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@uppy/svelte: fix exports condition #5416

Merged
merged 2 commits into from
Aug 20, 2024
Merged

@uppy/svelte: fix exports condition #5416

merged 2 commits into from
Aug 20, 2024

Conversation

Murderlon
Copy link
Member

@Murderlon Murderlon commented Aug 19, 2024

@Murderlon Murderlon requested a review from aduh95 August 19, 2024 08:32
@Murderlon Murderlon self-assigned this Aug 19, 2024
Copy link
Contributor

Diff output files
No diff

Copy link
Member

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a quick look at https://kit.svelte.dev/docs/packaging#anatomy-of-a-package-json-exports, I can confirm that indeed Svelte is expecting the built asset

packages/@uppy/svelte/package.json Outdated Show resolved Hide resolved
@Murderlon Murderlon merged commit 28c4baf into main Aug 20, 2024
17 checks passed
@Murderlon Murderlon deleted the svelte-exports branch August 20, 2024 14:06
github-actions bot added a commit that referenced this pull request Aug 21, 2024
| Package           | Version | Package           | Version |
| ----------------- | ------- | ----------------- | ------- |
| @uppy/core        |   4.1.2 | @uppy/transloadit |   4.1.0 |
| @uppy/status-bar  |   4.0.3 | uppy              |   4.2.0 |
| @uppy/svelte      |   4.0.1 |                   |         |

- @uppy/status-bar: show upload button when files are recovered (Merlijn Vos / #5418)
- meta: Bump docker/build-push-action from 6.6.1 to 6.7.0 (dependabot[bot] / #5413)
- docs: remove stale reference to plugins page (Merlijn Vos / #5414)
- @uppy/transloadit: add execution_progress to AssemblyResponse type (Merlijn Vos / #5420)
- @uppy/svelte: fix exports condition (Merlijn Vos / #5416)
- @uppy/transloadit: fix check if all files have been removed (Merlijn Vos / #5419)
- examples: remove `useUppy` from React Native example (Mikael Finstad / #5405)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uppy (4.1) does not work on a new Sveltekit (2.5.22) project
2 participants