disallow corsOrigins "*" #5496
Merged
disallow corsOrigins "*" #5496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because it could be a security risk https://app.intercom.com/a/inbox/qiqpfgjg/inbox/admin/4490996/conversation/26852700017788
Diff output filesdiff --git a/packages/@uppy/companion/lib/config/companion.js b/packages/@uppy/companion/lib/config/companion.js
index ee2dae0..542f378 100644
--- a/packages/@uppy/companion/lib/config/companion.js
+++ b/packages/@uppy/companion/lib/config/companion.js
@@ -110,6 +110,9 @@ const validateConfig = (companionOptions) => {
if (companionOptions.corsOrigins == null) {
throw new TypeError("Option corsOrigins is required. To disable security, pass true");
}
+ if (companionOptions.corsOrigins === "*") {
+ throw new TypeError("Option corsOrigins cannot be \"*\". To disable security, pass true");
+ }
if (
periodicPingUrls != null && (!Array.isArray(periodicPingUrls)
|| periodicPingUrls.some((url2) => |
Murderlon
approved these changes
Oct 29, 2024
github-actions bot
added a commit
that referenced
this pull request
Oct 31, 2024
| Package | Version | Package | Version | | ------------------------- | ------- | ------------------------- | ------- | | @uppy/aws-s3 | 4.1.1 | @uppy/provider-views | 4.0.2 | | @uppy/box | 3.1.1 | @uppy/react | 4.0.3 | | @uppy/companion | 5.1.3 | @uppy/react-native | 0.6.1 | | @uppy/companion-client | 4.1.1 | @uppy/redux-dev-tools | 4.0.1 | | @uppy/core | 4.2.3 | @uppy/screen-capture | 4.1.1 | | @uppy/dashboard | 4.1.2 | @uppy/status-bar | 4.0.4 | | @uppy/drag-drop | 4.0.4 | @uppy/store-default | 4.1.1 | | @uppy/dropbox | 4.1.1 | @uppy/store-redux | 4.0.1 | | @uppy/facebook | 4.1.1 | @uppy/svelte | 4.1.1 | | @uppy/file-input | 4.0.3 | @uppy/thumbnail-generator | 4.0.1 | | @uppy/form | 4.0.1 | @uppy/transloadit | 4.1.3 | | @uppy/golden-retriever | 4.0.1 | @uppy/tus | 4.1.3 | | @uppy/google-drive | 4.1.1 | @uppy/unsplash | 4.1.1 | | @uppy/google-photos | 0.3.1 | @uppy/url | 4.1.1 | | @uppy/image-editor | 3.2.0 | @uppy/utils | 6.0.4 | | @uppy/informer | 4.1.1 | @uppy/vue | 2.0.2 | | @uppy/instagram | 4.1.1 | @uppy/webcam | 4.0.2 | | @uppy/locales | 4.2.1 | @uppy/xhr-upload | 4.2.2 | | @uppy/onedrive | 4.1.1 | @uppy/zoom | 3.1.1 | | @uppy/progress-bar | 4.0.1 | uppy | 4.6.0 | - @uppy/xhr-upload: fix stale file references in events (Merlijn Vos / #5499) - @uppy/image-editor: upgrade cropperjs (Merlijn Vos / #5497) - @uppy/aws-s3,@uppy/box,@uppy/companion-client,@uppy/core,@uppy/dashboard,@uppy/drag-drop,@uppy/dropbox,@uppy/facebook,@uppy/file-input,@uppy/form,@uppy/golden-retriever,@uppy/google-drive,@uppy/google-photos,@uppy/image-editor,@uppy/informer,@uppy/instagram,@uppy/locales,@uppy/onedrive,@uppy/progress-bar,@uppy/provider-views,@uppy/react-native,@uppy/react,@uppy/redux-dev-tools,@uppy/screen-capture,@uppy/status-bar,@uppy/store-default,@uppy/store-redux,@uppy/svelte,@uppy/thumbnail-generator,@uppy/transloadit,@uppy/tus,@uppy/unsplash,@uppy/url,@uppy/utils,@uppy/vue,@uppy/webcam,@uppy/xhr-upload,@uppy/zoom: Fix links (Anthony Veaudry / #5492) - docs,@uppy/companion: disallow corsOrigins "*" (Mikael Finstad / #5496)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because it could be a security risk
https://app.intercom.com/a/inbox/qiqpfgjg/inbox/admin/4490996/conversation/26852700017788