-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't mark dependency packages as manually installed #1057
base: master
Are you sure you want to change the base?
Conversation
This was causing `apt-get` to refuse to install MariaDB unless one specifies all its corresponding dependency packages on the command line, too.
@travis-ci, any chance this patch gets some attention? The issue prevents the projects that build against MariaDB 10.1 from migrating from Trusty. |
@native-api while this proposal is in review, could you suggest a workaround that could be applied in a project's travis.yml file and effectively implemented the same logic that this patch does? E.g. a series of |
@morozov A workaround is to manually run the same commands that the addon does but select all 4 MariaDB packages as I did in https://travis-ci.org/native-api/test_travis/builds/593807343#L221. |
@native-api but didn't the build where you used the workaround fail? |
@morozov That's because the addon runs a number of other commands, too, that I didn't. I was only testing package conflict resolution. |
I see. I'm trying to migrate from Trusty to Xenial or Bionic and keep testing against several MariaDB versions (including 10.1). So practically, this workaround doesn't seem usable for me since your build failed with the message:
Even if the conflict was solved, there are other remaining issues that would still block the migration. |
This was causing
apt-get
to refuse to install MariaDB unless one specifies all its corresponding dependencies on the command line, too.What is the problem that this PR is trying to fix?
https://travis-ci.community/t/failures-installing-mariadb-10-2-on-xenial
What approach did you choose and why?
Fixing the problem at its source
How can you make sure the change works as expected?
The following should not cause apt install errors due to package conflict (but may cause an unrelated error on configuration stage, MariaDB addon is supposed to workaround it with its extra logic):
Would you like any additional feedback?