Add access control config to worker nodes #213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @nineinchnick PTAL |
|
Maybe @losipiuk |
losipiuk
reviewed
Aug 23, 2024
florianMalbranque
force-pushed
the
acces-control
branch
from
9d22955
to
51d4221
Compare
|
👋 @nineinchnick , addressed your reviews, PTAL |
florianMalbranque
force-pushed
the
acces-control
branch
from
eda9377
to
3d38e4f
Compare
nineinchnick
reviewed
Sep 4, 2024
| @@ -0,0 +1,15 @@ | |||
| {{- define "trino.accessControlConfigMap" -}} | |||
There was a problem hiding this comment.
Remove this define line, keep only the if block.
This was referenced Sep 25, 2024
|
Superseded by #226 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add access control config files to worker to enable graceful shutdown,
Fixes: trinodb/trino#22589