Extract query ID from all kill_query procedure variations #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmostly
force-pushed
the
will/test_extract_query_id_from_system_runtime_kill_query
branch
from
0f19b85
to
1ad0e45
Compare
mosabua
approved these changes
Aug 21, 2024
ebyhr
reviewed
Aug 24, 2024
gateway-ha/src/test/java/io/trino/gateway/ha/handler/TestQueryIdCachingProxyHandler.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/test/java/io/trino/gateway/ha/handler/TestQueryIdCachingProxyHandler.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/test/java/io/trino/gateway/ha/handler/TestQueryIdCachingProxyHandler.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/test/java/io/trino/gateway/ha/handler/TestQueryIdCachingProxyHandler.java
Outdated
Show resolved
Hide resolved
willmostly
force-pushed
the
will/test_extract_query_id_from_system_runtime_kill_query
branch
from
1ad0e45
to
a8355b6
Compare
willmostly
force-pushed
the
will/test_extract_query_id_from_system_runtime_kill_query
branch
from
a8355b6
to
83760bd
Compare
ebyhr
reviewed
Aug 30, 2024
gateway-ha/src/main/java/io/trino/gateway/ha/handler/ProxyUtils.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/test/java/io/trino/gateway/ha/handler/TestQueryIdCachingProxyHandler.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/test/java/io/trino/gateway/ha/handler/TestQueryIdCachingProxyHandler.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/test/java/io/trino/gateway/ha/handler/TestQueryIdCachingProxyHandler.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/test/java/io/trino/gateway/ha/handler/TestQueryIdCachingProxyHandler.java
Outdated
Show resolved
Hide resolved
willmostly
force-pushed
the
will/test_extract_query_id_from_system_runtime_kill_query
branch
from
9a00f3e
to
95e782a
Compare
willmostly
changed the title
ebyhr
reviewed
Sep 3, 2024
gateway-ha/src/main/java/io/trino/gateway/ha/handler/ProxyUtils.java
Outdated
Show resolved
Hide resolved
ebyhr
previously requested changes
Sep 4, 2024
willmostly
force-pushed
the
will/test_extract_query_id_from_system_runtime_kill_query
branch
from
95e782a
to
c311199
Compare
|
Needs a rebase now.. |
willmostly
force-pushed
the
will/test_extract_query_id_from_system_runtime_kill_query
branch
from
c311199
to
e9226b6
Compare
ebyhr
reviewed
Sep 13, 2024
| { | ||
| assertThat( | ||
| extractQueryIdIfPresent( | ||
| prepareMockRequestWithBody("CALL system.runtime.kill_query(query_id => '20200416_160256_03078_6b4yt', message => 'If he dies, he dies')"), |
There was a problem hiding this comment.
Please add a test case with uppercase procedure name KILL_QUERY.
| assertThat(extractQueryIdIfPresent(prepareMockRequestWithBody("call Kill_Query('20200416_160256_03078_6b4yt')"), ImmutableList.of())) | ||
| .isEqualTo("20200416_160256_03078_6b4yt"); | ||
|
|
||
| assertThat(extractQueryIdIfPresent(prepareMockRequestWithBody("select * from postgres.query_logs.queries where sql LIKE '%kill_query(''20200416_160256%' "), |
There was a problem hiding this comment.
Uppercase select, from and where.
ebyhr
reviewed
Sep 16, 2024
| assertThat(extractQueryIdIfPresent( | ||
| prepareMockRequestWithBody("select * from postgres.query_logs.queries where sql LIKE 'CALL kill_query(_20200416_160256_03078_6b4yt_)' "), | ||
| ImmutableList.of())) | ||
| .isNull(); |
There was a problem hiding this comment.
Please add more test cases. e.g.
The procedure exists in a comment
// CALL kill_query('20200416_160256_03078_6b4yt', 'If he dies, he dies')
SELECT 1Spaces exists
CALL kill_query ( '20200416_160256_03078_6b4yt', 'If he dies, he dies')New lines exist
CALL kill_query(
'20200416_160256_03078_6b4yt',
'If he dies, he dies')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trino Gateway attempts to extract the query id from the body of queries using the runtime.kill_query procedure from the system catalog. This adds a test for this functionality.
Additional context and related issues
Release notes
( x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: