Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing X-Trino-Time-Zone header from config #88

Closed
wants to merge 1 commit into from

Conversation

Yifeng-Sigma
Copy link
Contributor

No description provided.

@cla-bot
Copy link

cla-bot bot commented Sep 13, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link
Member

@nineinchnick nineinchnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some tests too? Ideally integration tests

@nineinchnick
Copy link
Member

@Yifeng-Sigma can you add some tests? If not, I can take this over.

@Yifeng-Sigma
Copy link
Contributor Author

@Yifeng-Sigma can you add some tests? If not, I can take this over.

Hey, feel free to take this over, thank you.

@nineinchnick
Copy link
Member

This should be fixed together with #119. I'll close it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants