Skip to content

Commit

Permalink
[NFC] Finish clean-up of #5834
Browse files Browse the repository at this point in the history
That partial revert left a couple auxiliary functions that are not
currently needed.
  • Loading branch information
lezcano committed Feb 6, 2025
1 parent ee1544c commit b88e5fc
Showing 1 changed file with 0 additions and 29 deletions.
29 changes: 0 additions & 29 deletions lib/Dialect/TritonGPU/Transforms/AccelerateMatmul.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -225,28 +225,6 @@ static bool bwdFilter(Operation *op) {
mlir::TypeID::get<arith::ArithDialect>());
}

static SmallVector<int, 2> getTransposeOrder(int rank) {
assert(rank >= 2);
auto transOrder = llvm::to_vector<2>(llvm::seq<int>(rank - 2));
transOrder.push_back(rank - 1);
transOrder.push_back(rank - 2);
return transOrder;
}

static DotOp transposeDotOp(PatternRewriter &rewriter, DotOp dotOp) {
auto rank = dotOp.getResult().getType().getRank();
Value a = dotOp.getA();
Value b = dotOp.getB();
Value c = dotOp.getC();
auto transOrder = getTransposeOrder(rank);
a = rewriter.create<TransOp>(a.getLoc(), a, transOrder);
b = rewriter.create<TransOp>(b.getLoc(), b, transOrder);
c = rewriter.create<TransOp>(c.getLoc(), c, transOrder);
return rewriter.create<DotOp>(dotOp.getLoc(), c.getType(), b, a, c,
dotOp.getInputPrecision(),
dotOp.getMaxNumImpreciseAcc());
}

// Finds the first different bitwidth in the chain of shape-preserving
// unary ops that x depends on.
// There are two primary scenarios:
Expand Down Expand Up @@ -336,7 +314,6 @@ class BlockedToMMA : public mlir::OpRewritePattern<DotOp> {

bool aFromLoad = comesFromLoadOrBlockArg(dotOp.getA());
bool bFromLoad = comesFromLoadOrBlockArg(dotOp.getB());
bool transpose = false;
auto origDotOp = dotOp;

Value a = dotOp.getA();
Expand Down Expand Up @@ -402,12 +379,6 @@ class BlockedToMMA : public mlir::OpRewritePattern<DotOp> {
dotOp.getInputPrecision(),
dotOp.getMaxNumImpreciseAcc());
}
if (transpose) {
auto rank = dotOp.getResult().getType().getRank();
auto transOrder = getTransposeOrder(rank);
newDot = rewriter.create<TransOp>(newDot->getLoc(), newDot->getResult(0),
transOrder);
}
// convert dot instruction
rewriter.replaceOpWithNewOp<ConvertLayoutOp>(origDotOp, origDotOp.getType(),
newDot->getResult(0));
Expand Down

0 comments on commit b88e5fc

Please sign in to comment.