Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Fix generating docs for tutorials #5850

Merged
merged 1 commit into from
Feb 7, 2025
Merged

[DOC] Fix generating docs for tutorials #5850

merged 1 commit into from
Feb 7, 2025

Conversation

Jokeren
Copy link
Contributor

@Jokeren Jokeren commented Feb 7, 2025

Do not exit when generating tutorials, which causes the whole documentation pipeline exit.

@Jokeren Jokeren requested a review from ptillet as a code owner February 7, 2025 15:22
@Jokeren
Copy link
Contributor Author

Jokeren commented Feb 7, 2025

Copy link
Collaborator

@ThomasRaoux ThomasRaoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. What's the right way to test it pre-commit?

@Jokeren
Copy link
Contributor Author

Jokeren commented Feb 7, 2025

Thanks. What's the right way to test it pre-commit?

I think we can run all tutorials in the CI pipeline, but it will increase the CI time probably by 4-5 minutes? Not sure if this is what we want

@ThomasRaoux
Copy link
Collaborator

Thanks. What's the right way to test it pre-commit?

I think we can run all tutorials in the CI pipeline, but it will increase the CI time probably by 4-5 minutes? Not sure if this is what we want

yeah, that might be a bit much. Is there a way to manually kick off the job?

@Jokeren
Copy link
Contributor Author

Jokeren commented Feb 7, 2025

yeah, that might be a bit much. Is there a way to manually kick off the job?

Yeah, that's what I did. https://github.com/triton-lang/triton/actions/workflows/documentation.yml

Go to this page and then choose a branch from Run workflow manually.

@ThomasRaoux
Copy link
Collaborator

yeah, that might be a bit much. Is there a way to manually kick off the job?

Yeah, that's what I did. https://github.com/triton-lang/triton/actions/workflows/documentation.yml

Go to this page and then choose a branch from Run workflow manually.

Thanks, I'll suggest it for the next big tutorial changes

@Jokeren Jokeren merged commit 80d9a94 into main Feb 7, 2025
8 checks passed
@Jokeren Jokeren deleted the keren/fix-doc branch February 7, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants