Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): BREAKING CHANGE refactor add-on system #31167

Draft
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

PrivatePuffin
Copy link
Member

@PrivatePuffin PrivatePuffin commented Jan 25, 2025

Description

This PR updates the add-on system to allow for more end-user flexibility
It basically moves add-on container configuration to values.yaml, to expose all container options to end users.

Fixes: #27351

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning
  • I made sure the title starts with feat(chart-name):, fix(chart-name): or chore(chart-name):

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

Copy link

github-actions bot commented Jan 25, 2025

✅ Deploy Preview ready!

Name Link
🔨 Latest commit bed6858
🔍 Latest deploy log https://github.com/truecharts/public/actions/runs/13092958688
😎 Deploy Preview Url
🌳 Environment

@PrivatePuffin PrivatePuffin changed the title feat(common): BREAKING CHANGE common add-on and dependency rework feat(common): Add resources to add-ons and showcase dependency changes Jan 25, 2025
@PrivatePuffin PrivatePuffin changed the title feat(common): Add resources to add-ons and showcase dependency changes feat(common): BREAKING CHANGE refactor add-on system Jan 25, 2025
@PrivatePuffin PrivatePuffin marked this pull request as ready for review January 25, 2025 16:25
@PrivatePuffin PrivatePuffin marked this pull request as draft January 31, 2025 10:21
Signed-off-by: Kjeld Schouten <[email protected]>
Signed-off-by: Kjeld Schouten <[email protected]>
Signed-off-by: Kjeld Schouten <[email protected]>
Signed-off-by: Kjeld Schouten <[email protected]>
Signed-off-by: Kjeld Schouten <[email protected]>
Signed-off-by: Kjeld Schouten <[email protected]>
@stavros-k stavros-k linked an issue Feb 2, 2025 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[common] Support for adding resouces to Addons
2 participants