feat(ecmascript): %TypedArray%.prototype.indexOf #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yossydev
changed the title
yossydev
force-pushed
the
feat/typed-array-index-of
branch
from
bc0ab6a to
56ab0ac
Compare
aapoalas
requested changes
Feb 3, 2025
.../ecmascript/builtins/indexed_collections/typed_array_objects/typed_array_intrinsic_object.rs
Outdated
Show resolved
Hide resolved
.../ecmascript/builtins/indexed_collections/typed_array_objects/typed_array_intrinsic_object.rs
Outdated
Show resolved
Hide resolved
.../ecmascript/builtins/indexed_collections/typed_array_objects/typed_array_intrinsic_object.rs
Outdated
Show resolved
Hide resolved
.../ecmascript/builtins/indexed_collections/typed_array_objects/typed_array_intrinsic_object.rs
Outdated
Show resolved
Hide resolved
.../ecmascript/builtins/indexed_collections/typed_array_objects/typed_array_intrinsic_object.rs
Outdated
Show resolved
Hide resolved
yossydev
force-pushed
the
feat/typed-array-index-of
branch
from
56ab0ac to
8e37b44
Compare
yossydev
force-pushed
the
feat/typed-array-index-of
branch
from
eb967cd to
06d6e34
Compare
aapoalas
requested changes
Feb 18, 2025
.../ecmascript/builtins/indexed_collections/typed_array_objects/typed_array_intrinsic_object.rs
Outdated
Show resolved
Hide resolved
.../ecmascript/builtins/indexed_collections/typed_array_objects/typed_array_intrinsic_object.rs
Outdated
Show resolved
Hide resolved
|
@aapoalas |
aapoalas
force-pushed
the
feat/typed-array-index-of
branch
from
4617743 to
3f7c9ea
Compare
aapoalas
approved these changes
Mar 2, 2025
There was a problem hiding this comment.
LGTM! There were some issues after the Value lifetime merge, I got to fixing those and also ended up taking a look at the rest of the failing indexOf tests. Those revealed some issues in both the indexOf impl and in our DataBlock implementation more deeply. I fixed those and now all should be good to go :)
Thank you <3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #145
doc: https://tc39.es/ecma262/multipage/indexed-collections.html#sec-%typedarray%.prototype.indexof