Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ecmascript): %TypedArray%.prototype.reverse #593

Merged
merged 5 commits into from
Mar 18, 2025
Merged

feat(ecmascript): %TypedArray%.prototype.reverse #593

merged 5 commits into from
Mar 18, 2025

Conversation

yossydev
Copy link
Contributor

aapoalas
aapoalas requested changes Mar 15, 2025
View reviewed changes
Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to do this in (roughly) the most performant way possible :)

@yossydev yossydev force-pushed the feat/typedarray-reverse branch from eeeee25 to a6b491b Compare March 18, 2025 12:28
@yossydev yossydev requested a review from aapoalas March 18, 2025 12:32
aapoalas
aapoalas requested changes Mar 18, 2025
View reviewed changes
Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can go deeper! :)

@yossydev
Copy link
Contributor Author

@aapoalas
Thanks! I made the slice itself mutable—so this was the correct approach after all! f4fd1b3

@yossydev yossydev requested a review from aapoalas March 18, 2025 12:59
aapoalas
aapoalas approved these changes Mar 18, 2025
View reviewed changes
Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice! <3

@aapoalas aapoalas merged commit d185e77 into trynova:main Mar 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aapoalas aapoalas aapoalas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yossydev @aapoalas