Improve log outputs #490
Open
Improve log outputs #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… store log file in CI artifacts
aspeake
commented
Mar 27, 2025
| @@ -25,7 +25,7 @@ jobs: | |||
| - name: Install Python dependencies | |||
| run: | | |||
| python -m pip install --upgrade pip | |||
| pip install flake8==6.0 | |||
| pip install flake8 | |||
There was a problem hiding this comment.
Previously had to set the version due to a bug, but that has been corrected with the current flake8.
aspeake
commented
Mar 27, 2025
Comment on lines
+43
to
+46
| # Write logger to console | ||
| console_handler = logging.StreamHandler() | ||
| console_handler.setFormatter(root_format) | ||
| logger.addHandler(console_handler) |
There was a problem hiding this comment.
All logging info is now printed to the console, this does not really change what was output, and mostly just replaces print statements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #404
Improve ecm_prep logging, updates include:
verboseprint()logger.info,logger.warning, orlogger.errorThis CI run shows the ecm_prep log file that is created and stored as an artifact, the new console outputs look like:
