-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
loads the rails engine for rails 8 versions #125
base: master
Are you sure you want to change the base?
Conversation
fixes #124 |
|
fixed |
Thanks, I used this to unblock my upgrade to v8. I wonder if rather than simply appending v8, whether it'd make more sense to tweak the conditional to always require the engine for v4+, otherwise we're going to be in the same position once v9 is released, and so on. Alternatively, maybe it's time to drop support for below Rails 4, then we can require the engine across the board without a version check, being more future-proof. Rails 3 last saw a release in 2016. Rails themselves are only currently supporting v7.2+, or v7.0+ when it comes to security issues. |
No description provided.