Toggling fullscreen #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgrojo
reviewed
Mar 25, 2024
raylib.ads
Outdated
| @@ -13,6 +13,12 @@ package Raylib is | |||
| Import => True, | |||
| Convention => C, | |||
| External_Name => "CloseWindow"; | |||
| procedure ToggleFullscreen | |||
There was a problem hiding this comment.
This should be Toggle_Fullscreen to be coherent with the conventional Ada style that Tsoding is using.
jiffygist
force-pushed
the
fullscreen
branch
2 times, most recently
from
cded84b to
f68dd75
Compare
|
I really don't like how ToggleFullscreen works on Windows. It literally tries to change the resolution of the entire screen to the size of the window. You resize the window to some weird size, ToggleFullscreen and it will try to change the resolution to that. We need to approach that differently. Maybe fix the resolution to specific value and forbid resize. Like, I don't know. I need to experiment and see what works the best. That's why I didn't implement it despite how seemingly simple the TODO sounds (Just slap the ToggleFullscreen and call it a day, right?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For desktops without "fake fullscreen" (like in i3, dwm and others).
These shortcuts are common in games.