Use debugger non user code attribute #350
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…classes to dictate whether to include the DebuggerNonUserCode attribute in generated code. Add this to the build task and associated classes and to the documentation.
|
PS reason for the new PR is that I screwed up my fork with a bunch of merge commits that aren't relevant |
sharwell
reviewed
May 31, 2020
| @@ -149,7 +150,8 @@ | |||
| GenerateVisitor="%(Antlr4.Visitor)" | |||
| ForceAtn="%(Antlr4.ForceAtn)" | |||
| AbstractGrammar="%(Antlr4.Abstract)" | |||
| UseCSharpGenerator="$(Antlr4UseCSharpGenerator)"> | |||
| UseCSharpGenerator="$(Antlr4UseCSharpGenerator)" | |||
| IncludeDebuggerNonUserCodeAttribute="$(IncludeDebuggerNonUserCodeAttribute)"> | |||
There was a problem hiding this comment.
Suggested change
| IncludeDebuggerNonUserCodeAttribute="$(IncludeDebuggerNonUserCodeAttribute)"> | |
| IncludeDebuggerNonUserCodeAttribute="%(Antlr4.IncludeDebuggerNonUserCodeAttribute)"> |
sharwell
reviewed
May 31, 2020
| if (UseCSharpGenerator) | ||
| { | ||
| if (IncludeDebuggerNonUserCodeAttribute) | ||
| arguments.Add("-DincludeDebuggerNonUserCodeAttribute"); |
There was a problem hiding this comment.
Suggested change
| arguments.Add("-DincludeDebuggerNonUserCodeAttribute"); | |
| arguments.Add("-DincludeDebuggerNonUserCodeAttribute=true"); |
sharwell
reviewed
May 31, 2020
| @@ -149,7 +149,7 @@ The following table describes the properties available for customizing the code | |||
| | `ForceAtn` | Force ATN | `True` or `False` | When `True`, the generated parser will use `AdaptivePredict` for all decisions, including LL(1) decisions. | | |||
| | `Listener` | Generate Listener | `True` or `False` | When `True`, a parse tree listener interface and base class will be generated for the parLitser. | | |||
| | `Visitor` | Generate Visitor | `True` or `False` | When `True`, a parse tree visitor interface and base class will be generated for the parser. | | |||
|
|
|||
| | `IncludeDebuggerNonUserCodeAttribute` | `Include DebuggerNonUserCode attribute` | `True` or `False` | When `True`, each method will have the DebuggerNonUserCode attribute attribute added. | | |||
There was a problem hiding this comment.
Suggested change
| | `IncludeDebuggerNonUserCodeAttribute` | `Include DebuggerNonUserCode attribute` | `True` or `False` | When `True`, each method will have the DebuggerNonUserCode attribute attribute added. | | |
| | `IncludeDebuggerNonUserCodeAttribute` | Include `DebuggerNonUserCode` attribute | `True` or `False` | When `True`, each method will have the DebuggerNonUserCode attribute attribute added. | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce new property that can be used in the OutputFile derived classes to dictate whether to include the DebuggerNonUserCode attribute in generated code.
Added this to the build task and associated classes and to the documentation.
I've not implemented it in the same way as abstract was implemented it as it would have meant introducing multiple properties (in Lexer and Parser) to do the same thing. Obviously happy to change this if that is the preferred option.
Closes #106