Introduce feature to query core database connection from within vtab module extensions #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality for a vtab module extension to hold and store a
Connectionfrom core, giving extensions the ability to query other tables associated with the open connection.This adds two API's currently,
ConnectionandStatement, which are public facing (extensions) and wrap theConnandStmtstructs which store the internal function pointers and context needed to perform the queries.I will mark this as a draft until #960 is merged and I can combine the
kvstoreandtestvfsextensions into one, so I can add a bunch of tests in 1 dummy extension. However I have tested the functionality of everything that's included in this PR, I just don't want to merge anything without extensive tests.