Syntax highlighting and hinting #1101
Conversation
cli/app.rs
Outdated
| row.add_cell( | ||
| Cell::new(content) | ||
| .set_alignment(alignment) | ||
| .fg(COLORS[idx & COLORS.len()]), |
| Cell::new(name).add_attribute(Attribute::Bold) | ||
| Cell::new(name) | ||
| .add_attribute(Attribute::Bold) | ||
| .fg(Color::AnsiValue(49)) // Green color for headers |
There was a problem hiding this comment.
I don't think the headers need to be the brightest parts of the table view. They're already the first line you see. We can make them a bit dimmer with AnsiValue(9)
There was a problem hiding this comment.
The AnsiValue(9) in this case would make the header red it would not dim it. To make it non bold you have to remove the Attribute::Bold. Regardless, I think this configuration could be the default and you can have a config file to change these little things to your preference.
| @@ -196,6 +196,8 @@ macro_rules! query_internal { | |||
| }}; | |||
| } | |||
|
|
|||
| static COLORS: &[Color] = &[Color::DarkRed, Color::DarkGreen, Color::DarkBlue]; | |||
There was a problem hiding this comment.
Can probably throw Color::DarkCyan, Color::DarkMagenta, Color::DarkYellow in there as well so it doesn't repeat immediately
There was a problem hiding this comment.
Yeah it could be a good default, I have to see how it would play out with a config file. I will get back to this after I have a configuration in mind
Start of syntax highlighting and hinting. Still need to figure out how to sublime-syntax works to produce good highlights.
Edit:
Personally, I believe there are more interesting syntax highlighting possibilities with
reedlinecrate, but currently, we cannot use it as the our DBConnectionwould have to beSend. This PR is an introduction and quality of life changes for the users of the CLI and for us developers, as we now won't have to look at black and white text only. I want to have a config file to personalize the color pallets, that will be made in a following PR.