[4/n]: migrate the RESTAPI GET /rest/* to use TwentyORM directly

[pacyL2K19]

This PR

• Addressing Make REST API use Twenty ORM direclty #3644
• Migrates the findOne and the findMany Rest API to use TwentyORM directly
• Adds integration tests to the migrated methods

[greptile-apps]

PR Summary

This PR migrates the GET endpoint in the REST API to use TwentyORM directly instead of going through GraphQL, improving performance by removing the intermediate GraphQL layer.

• Added new RestApiCoreServiceV2 in /packages/twenty-server/src/engine/api/rest/core/rest-api-core-v2.service.ts to handle direct TwentyORM operations
• Implemented filter processing system in getWhereFilter method but currently commented out in the GET implementation
• Added FilterInputFactory to RestApiModule for handling query filter parameters
• Switched GET endpoint in RestApiCoreController to use restApiCoreServiceV2.get() with RestApiExceptionFilter
• Commented out RequestMethod.GET from MIGRATED_REST_METHODS in app.module.ts to indicate work in progress

_{6 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile}

[pacyL2K19]

@martmull I think this PR is ready for a review

[martmull]

Hey, that's very nice code, concise and clear. I have left 2 some comments
Also, I see that depth query parameter is not taken into account in v2. @Weiko do you have an idea of how we can we do that with the twenty-orm ?

[pacyL2K19]

Hey, that's very nice code, concise and clear. I have left 2 some comments Also, I see that depth query parameter is not taken into account in v2. @Weiko do you have an idea of how we can we do that with the twenty-orm ?

Thank you for the review @martmull
We do have a ticket about the depth input, I will have to work on it after migrating the batch endpoint #9992

[Weiko]

Hey, that's very nice code, concise and clear. I have left 2 some comments Also, I see that depth query parameter is not taken into account in v2. @Weiko do you have an idea of how we can we do that with the twenty-orm ?

In graphql we use ProcessNestedRelations, we will probably something similar here

[pacyL2K19]

Hey, that's very nice code, concise and clear. I have left 2 some comments Also, I see that depth query parameter is not taken into account in v2. @Weiko do you have an idea of how we can we do that with the twenty-orm ?

In graphql we use ProcessNestedRelations, we will probably something similar here

Thanks for the hint @Weiko
I will be working on it later on in the process of this migration, we have a separate ticket already

[martmull]

LGTM, I still don't see where featureFlagsMap is useful here but it is not that important
Nice work thank you!

[prastoin]

Hey @martmull and @pacyL2K19, should this be merged ?
Rebased in order to manage conflicts with twenty-shared refactor, and also allow to run on latest twenty-server cicd

Remark: OrderByCondition marked as deprecated intypeorm

[pacyL2K19]

Hey @martmull and @pacyL2K19, should this be merged ? Rebased in order to manage conflicts with twenty-shared refactor, and also allow to run on latest twenty-server cicd

Remark: OrderByCondition marked as deprecated intypeorm

Hi @prastoin
Please gimme a day to clean up integration tests
I will follow up on this asap

About the depreciation of OrderByCondition, yes, I saw that, may be worth an entire ticket, jic

[prastoin]

Hi @pacyL2K19, obviously take your time no hurry ! Was just doing a tour on opened PRs

About the depreciation of OrderByCondition, yes, I saw that, may be worth an entire ticket, jic

Ok ! sounds good