-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REFACTOR] twenty-ui
multi barrel
#11203
Draft
prastoin
wants to merge
30
commits into
main
Choose a base branch
from
twenty-ui-multi-barrel
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twenty-ui
multi barrel
…s and destructured
Closing from now as need to refactor generate barrel in prior |
Need to handle: const toto = 'toto';
export {toto as FooBar};
const foo = 'foo';
const bar = 'bar';
export { foo, bar };
export const {foo, bar} = {foo: 'foo', bar: 'bar'};
export const {foo: somehow, bar} = {foo: 'foo', bar: 'bar'}; |
Should add to migration script the |
has to fix AppRootErrorFallback manually by consuming theme directly motion } from 'framer-motion';
import { IconReload } from 'twenty-ui/display';
import { GRAY_SCALE, THEME_LIGHT } from 'twenty-ui/theme';
type AppRootErrorFallbackProps = AppErrorDisplayProps;
const StyledContainer = styled.div`
background: ${THEME_LIGHT.background.noisy};
box-sizing: border-box;
display: flex;
height: 100vh;
width: 100vw; |
I need to handle lingui using babel |
Tags.tsx has a circular dep, omitting from now error twenty-ui EvalError: Circular dependency detected: /Users/paulrastoin/ws/twenty/node_modules/@emotion/react/dist/emotion-element-b1930563.cjs.js -> /Users/paulrastoin/ws/twenty/node_modules/@emotion/react/dist/emotion-react.cjs.js -> /Users/paulrastoin/ws/twenty/packages/twenty-ui/src/theme/constants/HoverBackground.ts -> /Users/paulrastoin/ws/twenty/packages/twenty-ui/src/theme/index.ts -> /Users/paulrastoin/ws/twenty/packages/twenty-ui/src/display/tag/components/Tag.tsx -> /Users/paulrastoin/ws/twenty/node_modules/@emotion/cache/dist/emotion-cache.cjs.js in/Users/paulrastoin/ws/twenty/node_modules/@emotion/react/dist/emotion-element-b1930563.cjs.js
🎁 error twenty-ui | /Users/paulrastoin/ws/twenty/node_modules/@emotion/react/dist/emotion-react.cjs.js
🎁 error twenty-ui | /Users/paulrastoin/ws/twenty/packages/twenty-ui/src/theme/constants/HoverBackground.ts
🎁 error twenty-ui | /Users/paulrastoin/ws/twenty/packages/twenty-ui/src/theme/index.ts
🎁 error twenty-ui | /Users/paulrastoin/ws/twenty/packages/twenty-ui/src/display/tag/components/Tag.tsx |
Sometimes twenty-front just crashes
|
[wyw-in-js] /Users/paulrastoin/ws/twenty/packages/twenty-ui/dist/objectSpread2-c2a27e3d.esm.js has a module-resolver plugin in its babelrc, but it is not present in the babelOptions for the wyw-in-js plugin. This works for now but will be an error
in the future. Please add the module-resolver plugin to the babelOptions for the wyw-in-js plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
WIP