Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow installation with lunr 0.8 #880

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

carlwgeorge
Copy link
Contributor

@carlwgeorge carlwgeorge commented Mar 18, 2025

Lunr has released version 0.8.0. It is still compatible with lunr.js version 2.3.9 that is bundled in this project.

https://github.com/yeraydiazdiaz/lunr.py/blob/0.8.0/lunr/__init__.py#L6

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.85%. Comparing base (43bee3e) to head (84b5863).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #880   +/-   ##
=======================================
  Coverage   92.85%   92.85%           
=======================================
  Files          47       47           
  Lines        8528     8528           
  Branches     1573     1573           
=======================================
  Hits         7919     7919           
  Misses        348      348           
  Partials      261      261           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tristanlatr
Copy link
Contributor

tristanlatr commented Mar 18, 2025

Hello @carlwgeorge, many thanks for your contribution!

I’d prefer to keep some sort of pinning since the lunr python package is designed to be compatible with only one lunrjs version at a time. So if lunrjs release a new version and that we don’t update right away, the Python dependency will become incompatible with our vendored lunrjs.

So would you please change it so it’s using the upper bound 0.9.0?

Thanks a lot,

Lunr has released version 0.8.0.  It is still compatible with lunr.js
version 2.3.9 that is bundled in this project.

https://github.com/yeraydiazdiaz/lunr.py/blob/0.8.0/lunr/__init__.py#L6
@carlwgeorge carlwgeorge force-pushed the remove-lunr-upper-bound branch from af6a828 to 84b5863 Compare March 18, 2025 17:53
@carlwgeorge carlwgeorge changed the title Remove lunr dependency upper bound ~Remove lunr dependency upper bound~ Allow installation with lunr 0.8 Mar 18, 2025
@carlwgeorge carlwgeorge changed the title ~Remove lunr dependency upper bound~ Allow installation with lunr 0.8 ~~Remove lunr dependency upper bound~~ Allow installation with lunr 0.8 Mar 18, 2025
@carlwgeorge carlwgeorge changed the title ~~Remove lunr dependency upper bound~~ Allow installation with lunr 0.8 Allow installation with lunr 0.8 Mar 18, 2025
@carlwgeorge
Copy link
Contributor Author

Sure, rebased with a new commit message.

@tristanlatr tristanlatr merged commit 2b5e910 into twisted:master Mar 18, 2025
35 of 36 checks passed
@tristanlatr
Copy link
Contributor

Thanks a lot!

@carlwgeorge carlwgeorge deleted the remove-lunr-upper-bound branch March 18, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants