Add tests for NavigationBar #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 31, 2025 10:32
…tain html tag or attribute is in a String. These aren't appropriate for general use, but should work fine for testing purposes
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a few methods on String in the test target that make searching for html tags and attributes simpler (in a testing environment only, these obviously aren't robust enough for general work)
Using these methods, I added tests for the structure of the output of NavigationBar as well as for the various parameters that can be applied to NavigationBar.
I had to make one change to NavigationBar.Width, making it Sendable so that it can be parameterized in the tests.
idk, maybe the String extensions should be in a separate PR, but I thought that providing an example of their usefulness would be appropriate. Please advise